[Jobs][Consolidation] Signal file for api restart #7560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/smoke-test --managed-jobs |
cg505
reviewed
Oct 10, 2025
Collaborator
cg505
left a comment
cg505
left a comment
There was a problem hiding this comment.
Thanks!
Can we add a smoke test checking that the warning gets printed?
Co-authored-by: Christopher Cooper <[email protected]>
Collaborator
Author
Added! PTAL again. |
cg505
approved these changes
Oct 14, 2025
Collaborator
Author
|
/smoke-test --managed-jobs |
kevinmingtarja
added a commit
that referenced
this pull request
Oct 14, 2025
This reverts commit 40995a2.
5 tasks
kevinmingtarja
added a commit
that referenced
this pull request
Oct 14, 2025
)"" This reverts commit e3056cb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling consolidation mode, user needs to restart the API server to:
This PR adds a signal file to indicating this restart process and print out warnings for user to restart the api server.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)